Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reported profiling stack frame count #886

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Feb 22, 2024

profiling.data.total.frame.count should be the amount of total frames, not stacktraces.

@seemk seemk requested review from a team as code owners February 22, 2024 16:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee90b71) 85.97% compared to head (01b58e4) 85.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          19       19           
  Lines         670      670           
  Branches      154      154           
=======================================
  Hits          576      576           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seemk seemk merged commit 6bed434 into main Feb 22, 2024
129 checks passed
@seemk seemk deleted the fix-profiling-frame-count branch February 22, 2024 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants