Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable log sending for Winston by default, add winston-transport #941

Merged
merged 2 commits into from
Aug 30, 2024
Merged

disable log sending for Winston by default, add winston-transport #941

merged 2 commits into from
Aug 30, 2024

Conversation

seemk
Copy link
Collaborator

@seemk seemk commented Aug 30, 2024

  • Make sure log sending is disabled for winston unless enabled explicitly.
  • Add winston-transport dependency, required when log sending is enabled.
  • Improve instrumentation typings.

Fixes #930

@seemk seemk requested review from a team as code owners August 30, 2024 12:35
@seemk seemk merged commit 11f5dc9 into main Aug 30, 2024
130 checks passed
@seemk seemk deleted the disable-winston-log-sending branch August 30, 2024 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t2t2 t2t2 t2t2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing Dependency in @splunk/otel
2 participants
@seemk @t2t2