Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI pipeline and bump supported ns-3 version to ns-3.43 #173

Merged
merged 18 commits into from
Oct 13, 2024

Conversation

non-det-alle
Copy link
Collaborator

@non-det-alle non-det-alle commented Oct 10, 2024

Ns-3.43 introduces the following changes to the CI pipeline:

  • Remove explicit CodeQL job and rely on automatic GitHub scans
  • Update doxygen version used for generating docs, as well as clang-tidy and format versions

The following maintenance changes to this repo's CI are also applied:

  • Remove repo actions that do not remove CI code duplication
  • Align workflow naming scheme, minor fixes on comments and printing
  • Codecov: Code compilation mode to default, and official GitHub action in place of deprecated script

Notable changes to module files brought by ns-3.43:

  • All GPL licence text in files becomes SPDX licence

Ns-3.43 also removes dependency of the propagation module's tests on the applications module. In the past, the lowest compilation time could only be achieved via --enable-modules "lorawan;applications", as we did in our CI jobs. Now configuring ns-3 with just --enable-modules lorawan still leads to all tests passing but with a lower compilation time. Yay! See this ns-3 issue for more details.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (e99f688) to head (7d5b4f0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
model/class-a-end-device-lorawan-mac.cc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
+ Coverage    76.25%   77.68%   +1.43%     
===========================================
  Files           69       66       -3     
  Lines         5436     6844    +1408     
===========================================
+ Hits          4145     5317    +1172     
- Misses        1291     1527     +236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@non-det-alle
Copy link
Collaborator Author

non-det-alle commented Oct 10, 2024

Note: The decrease in test coverage signaled by Codecov is expected, as now we run coverage checks with the default build mode instead of release, thus also including logs as part of the code built and tested. This should be automatically fixed by future commits.

@non-det-alle non-det-alle force-pushed the ns-3.43-ci branch 6 times, most recently from 3ee4dc7 to 5a205d5 Compare October 12, 2024 21:49
@non-det-alle non-det-alle force-pushed the ns-3.43-ci branch 3 times, most recently from 151eb55 to 9b41524 Compare October 13, 2024 10:30
@non-det-alle
Copy link
Collaborator Author

Fixed Codecov CI error by extending test coverage to buildings model via an example's parameter in tests

@non-det-alle non-det-alle merged commit 17b213f into develop Oct 13, 2024
20 checks passed
@non-det-alle non-det-alle deleted the ns-3.43-ci branch October 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant