Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer explicit DynamicCast in place of GetObject for downcasting #176

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

non-det-alle
Copy link
Collaborator

Refactor GetObject uses to explicit DynamicCast when actually downcasting (i.e. not getting an aggregated object).
See Downcasting from the Object Model section of the ns-3 manual.

This PR is an effort to break #135 into more digestible pieces.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (17b213f) to head (40735bf).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
model/end-device-lorawan-mac.cc 33.33% 4 Missing ⚠️
helper/lorawan-mac-helper.cc 80.00% 3 Missing ⚠️
model/class-a-end-device-lorawan-mac.cc 92.30% 1 Missing ⚠️
model/lora-channel.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
- Coverage    77.68%   77.66%   -0.03%     
===========================================
  Files           66       66              
  Lines         6844     6831      -13     
===========================================
- Hits          5317     5305      -12     
+ Misses        1527     1526       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@non-det-alle non-det-alle merged commit 82ea58a into develop Oct 21, 2024
20 checks passed
@non-det-alle non-det-alle deleted the dynamic-cast branch October 21, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants