Skip to content

Commit

Permalink
fix error message after rename Load -> Terminal
Browse files Browse the repository at this point in the history
  • Loading branch information
@olmobrutall
olmobrutall committed Feb 10, 2020
1 parent 43eec06 commit e5abacb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Signum.Engine/Engine/Synchronizer.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ private static Selection SelectInteractive(string oldValue, List<string> newValu
}

if (!interactive)
throw new InvalidOperationException("Impossible to synchronize {0} without interactive Console. Consider running the Load project.".FormatWith(replacementsKey));
throw new InvalidOperationException("Unable to ask for renames to synchronize {0} without interactive Console. Please use your Terminal application".FormatWith(replacementsKey));

int startingIndex = 0;
Console.WriteLine();
Expand Down

2 comments on commit e5abacb

@olmobrutall
Copy link
Collaborator Author

@olmobrutall olmobrutall commented on e5abacb Feb 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename Southwind.Load to Southwind.Terminal

This commit in southwind renames Southinwd.Load to Southwind.Terminal. It's not actually a breaking change in Signum Framework, but it's a new convention that will be used moving forward in tutorials and error messages, so better rename in your application too.

Why the change?

The name Load was chosen a long time ago, even before the framework existed, and doesn't really fit anymore. When training, there is often a confusion with the Load application.

  • The name Load is too similar to Logic
  • The alphabetical order Entities, Load, Logic, React, Test is not a valid compilation order, while Entities, Logic, React, Terminal, Test is.
  • There are ways to load stuff using the react application (like user assets), and the Load application does more things than loading, like running Sql migrations or exporting AuthRules. What is fundamental about the Load application is that it uses the Console to do IO.

Other names where considered, like Southwind.Console (many conflicts with the System.Console class), Southwind.CLI, Southwind.Prompt or Southwind.Shell (more a command interpreter than a text IO app).

Long live to Southwind.Terminal!

@MehdyKarimpour
Copy link
Contributor

@MehdyKarimpour MehdyKarimpour commented on e5abacb Feb 10, 2020 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.