-
Notifications
You must be signed in to change notification settings - Fork 84
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'doganc/Precision'
# Conflicts: # Signum.Engine/CodeGeneration/EntityCodeGenerator.cs # Signum.Engine/Connection/Connector.cs # Signum.Engine/Connection/PostgreSqlConnector.cs # Signum.Engine/Connection/SqlServerConnector.cs # Signum.Engine/Engine/SchemaSynchronizer.cs # Signum.Engine/Engine/SqlBuilder.cs # Signum.Engine/Engine/SqlPreCommand.cs # Signum.Engine/Schema/Schema.Basics.cs # Signum.Engine/Schema/Schema.Save.cs # Signum.Engine/Schema/SchemaBuilder/SchemaBuilder.cs # Signum.Engine/Schema/SchemaBuilder/SchemaSettings.cs # Signum.Engine/Signum.Engine.csproj # Signum.Entities/FieldAttributes.cs # Signum.Entities/ValidationAttributes.cs
- Loading branch information
Showing
14 changed files
with
8,508 additions
and
8,409 deletions.
There are no files selected for viewing
1,395 changes: 701 additions & 694 deletions
1,395
Signum.Engine/CodeGeneration/EntityCodeGenerator.cs
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
1,523 changes: 763 additions & 760 deletions
1,523
Signum.Engine/Schema/SchemaBuilder/SchemaBuilder.cs
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
fe17abd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split between Size and Precission
Thanks to the awesome PR from @rezanos we get three improvements:
DbTypeAttribute
and internally there is now a clean split betweenSize
(for strings or binary columns) andPrecision
andScale
(for Decimal columns) that are now of typebyte
.Size
,Precission
andScale
are now set explicitly in allSqlParamter
, this fixes a problem with Always Encrypt in decimal columns. https://stackoverflow.com/questions/45748113/use-always-encrypted-on-decimal18-2Microsoft.Data.SqlClient 4.0.0
Aditionally this PR updates Signum.Engine to Microsoft.Data.SqlClient 4.0.0
This new version has an important breaking change, they have turned connection encryption to true by default, in an effort to increase the security level (like when browsers went from default HTTP to HTTPS)
The upgrade
Upgrade_20211219_MicrosoftDataSqlClient
will try to fix your connection strings by replacing:"Integrated Security=true"
->"Integrated Security=true;TrustServerCertificate=true"
If your connection strings do not have Integrated Security=true, you will need to update them manually.
fe17abd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fe17abd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 Thanks to your excellent help and guidance, as always 👍