Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Don't quote slot and epoch, for now #1597

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Don't quote slot and epoch, for now #1597

wants to merge 1 commit into from

Conversation

michaelsproul
Copy link
Member

Fixes a breaking change to our API that was unnecessary and can wait until #1569 is merged

@michaelsproul michaelsproul added low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review labels Sep 8, 2020
@michaelsproul michaelsproul mentioned this pull request Sep 8, 2020
Closed
paulhauner
paulhauner approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merely a temporary reprieve from the inevitable future where QUOTES REIGN SUPREME!

bors r+

bors bot pushed a commit that referenced this pull request Sep 8, 2020
@michaelsproul
Don't quote slot and epoch, for now (#1597)
19be7ab 
Fixes a breaking change to our API that was unnecessary and can wait until #1569 is merged
@bors
Copy link

bors bot commented Sep 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Don't quote slot and epoch, for now [Merged by Bors] - Don't quote slot and epoch, for now Sep 8, 2020
@bors bors bot closed this Sep 8, 2020
@michaelsproul michaelsproul deleted the no-quote-slot branch September 8, 2020 03:20
@michaelsproul michaelsproul mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @paulhauner