[Merged by Bors] - Limit snappy input stream #1738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
changed the title
protolambda
reviewed
Oct 6, 2020
AgeManning
reviewed
Oct 8, 2020
There was a problem hiding this comment.
This looks good. Nice work!
Although a little more effort, I think we might benefit from implementing an RPC Limit struct type with max and min fields rather than the tuple.
I think it will make the code a little more readable and hopefully prevent mixing up the tuple indexes when doing things like length > limit.1 || length < limit.0
What do you think?
|
Agree this is ugly. Will make the changes :) |
AgeManning
approved these changes
Oct 11, 2020
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2020
## Issue Addressed N/A ## Proposed Changes This PR limits the length of the stream received by the snappy decoder to be the maximum allowed size for the received rpc message type. Also adds further checks to ensure that the length specified in the rpc [encoding-dependent header](https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/p2p-interface.md#encoding-strategies) is within the bounds for the rpc message type being decoded.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
This PR limits the length of the stream received by the snappy decoder to be the maximum allowed size for the received rpc message type. Also adds further checks to ensure that the length specified in the rpc encoding-dependent header is within the bounds for the rpc message type being decoded.