Fix Uint256 deserialization #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
FYI clippy is unhappy and I've made some suggestions to Sean's PR which you might cause conflicts (I don't think they will). I'll give this a review once Sean's PR goes into Kintsugi and the diff is clean 🚀 |
pawanjay176
force-pushed
the
ssz-fixes
branch
from
e03ec64
to
cd263f6
Compare
pawanjay176
force-pushed
the
ssz-fixes
branch
from
cd263f6
to
74bfb29
Compare
pawanjay176
added
ready-for-review
paulhauner
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Very nice and clean!
I wrote a quick test to double-check my understand over at paulhauner@032ffd2. It might be nice to cherry-pick that on this branch. Up to you.
Feel free to squash-merge into kintsugi when you're happy :)
paulhauner
reviewed
Nov 10, 2021
paulhauner
reviewed
Nov 10, 2021
paulhauner
added a commit
that referenced
this pull request
Nov 11, 2021
* Change base_fee_per_gas to Uint256 * Add custom (de)serialization to ExecutionPayload * Fix errors * Add a quoted_u256 module * Remove unused function * lint * Add test * Remove extra line Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* Change base_fee_per_gas to Uint256 * Add custom (de)serialization to ExecutionPayload * Fix errors * Add a quoted_u256 module * Remove unused function * lint * Add test * Remove extra line Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* Change base_fee_per_gas to Uint256 * Add custom (de)serialization to ExecutionPayload * Fix errors * Add a quoted_u256 module * Remove unused function * lint * Add test * Remove extra line Co-authored-by: Paul Hauner <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Dec 2, 2021
* Change base_fee_per_gas to Uint256 * Add custom (de)serialization to ExecutionPayload * Fix errors * Add a quoted_u256 module * Remove unused function * lint * Add test * Remove extra line Co-authored-by: Paul Hauner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Builds upon @realbigsean 's merge spec test fixes from #2781. Add a
quoted_u256module ineth2_serde_utilsto correctly decode Uint256 values from string.Additional Info
Had to add the
ethereum-typesdependency toserde_utilsand use the local crate instead of the published version.We could also move the
quoted_u256module totypesinstead if we want to use the published version.