[Merged by Bors] - Use "release candidate" in book #2920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
## Issue Addressed NA ## Proposed Changes Since we use the `rc` (release candidate) tag in our version strings, it seems consistent if we also use "release candidate" in the book rather than "pre-release". Notably, Github adds a "pre-release" tag to release when we request. I think it's OK that Github uses that term whilst we consistently use "release candidate". Our docs indicate that the terms are interchangeable. ## Additional Info I hope to use the new docs link in the `v2.1.0` release, so it would be nice if we can merge this soon 🙏
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
|
The pre-releases page is linking to itself here, so I think the release candidates page wasn't linked to from anywhere. I fixed that in this PR because I was working on the docs in the same area: #2808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Since we use the
rc(release candidate) tag in our version strings, it seems consistent if we also use "release candidate" in the book rather than "pre-release".Notably, Github adds a "pre-release" tag to release when we request. I think it's OK that Github uses that term whilst we consistently use "release candidate". Our docs indicate that the terms are interchangeable.
Additional Info
I hope to use the new docs link in the
v2.1.0release, so it would be nice if we can merge this soon 🙏