Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - require http and metrics for respective flags #4674

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - require http and metrics for respective flags #4674

wants to merge 6 commits into from

Commits on Aug 28, 2023

  1. require http and metrics for respective flags

    @jxs
    jxs committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    47acde7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. update default to default_if to comply with requires

    @jxs
    jxs committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    151d60f View commit details
    Browse the repository at this point in the history

  2. remove unrequired required flags 

    default is false
    @jxs
    jxs committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    bed073f View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. require http flag for http subflags for beacon node

    @jxs
    jxs committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5abe243 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. make enable_http a group with http, gui, and staking

    @jxs
    jxs committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    22e6177 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. check for enable_http arggroup instead of http, 

    to both add default values and then require them, fixes doppelganger protection test
    @jxs
    jxs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ce849eb View commit details
    Browse the repository at this point in the history