Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix cli options #4772

Closed
wants to merge 1 commit into from
Closed

Conversation

jxs
Copy link
Member

@jxs jxs commented Sep 22, 2023

Issue Addressed

Fixes breaking change introduced on #4674 that doesn't allow multiple http_enabled ArgGroup flags

@jxs jxs changed the base branch from stable to unstable September 22, 2023 09:40
@paulhauner paulhauner added the v4.5.0 ETA Q4 2023 label Sep 22, 2023
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, easy fix!

@paulhauner paulhauner added the ready-for-merge This PR is ready to merge. label Sep 22, 2023
@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 22, 2023
## Issue Addressed

Fixes breaking change introduced on #4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
@bors
Copy link

bors bot commented Sep 22, 2023

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 22, 2023
## Issue Addressed

Fixes breaking change introduced on #4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
@bors
Copy link

bors bot commented Sep 22, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 22, 2023
## Issue Addressed

Fixes breaking change introduced on #4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
@bors
Copy link

bors bot commented Sep 22, 2023

@bors bors bot changed the title Fix cli options [Merged by Bors] - Fix cli options Sep 22, 2023
@bors bors bot closed this Sep 22, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Fixes breaking change introduced on sigp#4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Fixes breaking change introduced on sigp#4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Fixes breaking change introduced on sigp#4674  that doesn't allow multiple `http_enabled` `ArgGroup` flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v4.5.0 ETA Q4 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants