Add purge-db-safe flag which requires manual confirmation
#5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
enhancement
|
What about waiting for 5.0.0 and sliding a breaking change to make |
Yeah happy to do that. I do think we should have two flags regardless, so automated setups have an option. |
dapplion
reviewed
Apr 2, 2024
| let blobs_db = client_config.get_blobs_db_path(); | ||
| purge_db(chain_db, freezer_db, blobs_db)?; | ||
| } else { | ||
| eprintln!("Database was not deleted."); |
There was a problem hiding this comment.
Should you error exit here instead of ignoring the request to purge the DB?
jimmygchen
added
waiting-on-author
|
Closed in favour of #6154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5028
Proposed Changes
Add a new flag called
--purge-db-safewhich functions like--purge-dbbut requires manual confirmation. As such it is not suitable for environments that are designed to be automated.Additional Info
I moved the
stdin-inputsflag to be a global flag under thelighthousecommand, as I felt this is a cleaner solution than currently, even if not every subcommand will use it. Happy to change it back if someone has a different opinion.