Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade clap and move to derive #5231

Closed
wants to merge 20 commits into from
Closed

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Feb 13, 2024

Issue Addressed

#5087

Proposed Changes

Upgrade clap to v4.5 and move to derive for some better compile time guarantees. It also makes the cli flags easier to reason about and lays the ground work for ingesting cli values from config files

Additional Info

@eserilev
Copy link
Collaborator Author

eserilev commented Feb 16, 2024

EDIT:
We found a way to work with both clap derive and clap builder which means we could move to dervie crate by crate, instead of all at once. This will require us to upgrade clap to v4.5 first, Im working on that PR now

@eserilev eserilev marked this pull request as ready for review February 19, 2024 09:43
@eserilev eserilev changed the title [WIP] Upgrade clap and move to derive Upgrade clap and move to derive Feb 19, 2024
@eserilev
Copy link
Collaborator Author

Closing in favor of #5273

I will still be using the work I did here when migrating to clap derive. However we'll be migrating to clap derive on a crate by crate basis, instead of all at once, to make the PRs more manageable

@eserilev eserilev closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant