Uncomment self_hosted_runner after PR Merge #5137 #5291

Arvmor · 2024-02-25T07:26:15Z

Issue Addressed

as PR #5157 is merged, uncommented since the version of lcli is installed on the runners
Which issue # does this PR address?
#4847 & PR #5137

Proposed Changes

Please list or describe the changes introduced by this PR.
uncommented SELF_HOSTED_RUNNERS
in test-suite.yml

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

CLAassistant · 2024-02-25T07:26:21Z

All committers have signed the CLA.

antondlr · 2024-02-27T08:59:07Z

this is not yet ready to be merged, lcli on our runners does not auto-update
I'll put it on the todo and merge this when ready

Arvmor · 2024-02-28T19:21:15Z

@antondlr sure thank you!

antondlr

lgtm!

Arvmor · 2024-03-09T00:25:52Z

do i have to change the branch to stable?

antondlr · 2024-03-09T13:07:52Z

do i have to change the branch to stable?

no, targeting unstable is fine. we're prepping a release now, this will be merged for the next one.

michaelsproul · 2024-04-30T06:49:54Z

@Mergifyio queue

mergify · 2024-04-30T06:50:00Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Squashed commit of the following: commit a62a8fc Merge: 86ceda6 40d4126 Author: realbigsean <[email protected]> Date: Mon Apr 29 14:20:23 2024 -0400 Merge branch 'unstable' into fix_todo commit 86ceda6 Author: Arvin Morawej <[email protected]> Date: Sun Feb 25 02:20:16 2024 -0500 Uncomment self_hosted_runner after PR Merge #5137

jimmygchen · 2024-04-30T11:43:32Z

We need a newer version of lcli installed on the runner (electra support) before re-queuing this.

…x_todo

realbigsean · 2024-04-30T19:00:09Z

@mergify queue

mergify · 2024-04-30T19:00:24Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at aea02c6

* Fix execution integration tests (#5647) * update waiting status * revert to old nethermind version * Add electra presets to beacon API (#5630) * add presets to API * add extra fields to config spec in beacon API * remove unused * add mainnet presets for gnosis and fix minimal preset default values * Rename `Merge` to `Bellatrix` (#5601) * Rename Merge to Bellatrix * Remove tree-hash-cache which got readded from the rebase * Deterministic block generation for tests (#5654) * Deterministic block generation for tests * Electra other containers (#5652) * add new fields to execution payload and header * beacon state changes * partial beacon state * safe arith in upgrade to electra * initialize balances cache in interop genesis state * Revert "initialize balances cache in interop genesis state" This reverts commit c60b522. * always initialize balances cache if necessary in electra upgrade * build cache earlier * fix block test * per fork NUM_FIELDS_POW2 * Merge branch 'unstable' of https://github.com/sigp/lighthouse into electra-other-containers * fix lints * get fields based on post state, as is spec'd * fix type and move cache build * Add more electra helpers (#5653) * Add new helpers * Fix some stuff * Fix compilation errors * lint * Address review * Ignore gossip blob already imported (#5656) * Ignore gossip blob already imported * Beta compiler fix (#5659) * fix beta compiler compilation * remove unused import * Revert "remove unused import" This reverts commit 0bef36b. * Revert "fix beta compiler compilation" This reverts commit 23152cf. * rename ununsed fields * allow dead code on some error variants * remove unused blob download queue * add back debug to backfill error * more allow dead code on errors * fix(validator_client): raise soft fd limit (#4796) * fix(validator_client): raise soft fd limit * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * cargo lock * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * Proposer and attester slashing sse events (#5327) * default vc to block v3 endpoint and deprecate block-v3 flag * Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable * add proposer and attester event variants * add TOOOs * add tests, event triggers * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * revert * revert * remove double event tracking * Merge branch 'unstable' into proposer-and-attester-slashing-sse-events * remove todo, fix test * resolve merge conflicts * Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events * leftover debugging * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * pin macos release runner to `macos-13` (#5665) * pin macos release runner to `macos-13` * Update .github/workflows/release.yml * Remove snapshot cache related code (#5661) * Remove snapshot cache and other references. * Fix default state cache size in docs * Remove cache miss comment entirely * Add state cache CLI tests * Uncomment self_hosted_runner after PR Merge #5137 (#5291) * Uncomment self_hosted_runner after PR Merge #5137 * Merge branch 'unstable' into fix_todo * Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo * Only `portable` builds (binaries) (#5615) * release workflow: portable builds by default * Delete outdated comment * Merge branch 'unstable' into portable-builds-binaries # Conflicts: # .github/workflows/release.yml * Merge parent and current sync lookups (#5655) * Drop lookup type trait for a simple arg * Drop reconstructed for processing * Send parent blocks one by one * Merge current and parent lookups * Merge current and parent lookups clean up todos * Merge current and parent lookups tests * Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup * Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup * fix compile after merge * #5655 pr review (#26) * fix compile after merge * remove todos, fix typos etc * fix compile * stable rng * delete TODO and unfilled out test * make download result a struct * enums instead of bools as params * fix comment * Various fixes * Track ignored child components * Track dropped lookup reason as metric * fix test * add comment describing behavior of avail check error * update ordering * delete spammy log (#5672) * delete spammy log * Ensure block only range requests don't fail on download (#5675) * ensure pruned blobs don't fail on download * Typo * Improve ENR updates (#5483) * Improve ENR updates * forever fmt * Appease my old friend clippy * Merge network unstable * Check da_checker before doing a block lookup request (#5681) * Check da_checker before doing a block lookup request * Ensure consistent handling of lookup result * use req resp pre import cache rather than da checker * Update Cargo.lock (#5670) * update rust-yamux * update Cargo.lock * Merge branch 'unstable' of github.com:jxs/lighthouse into update-cargo * Merge branch 'unstable' of github.com:sigp/lighthouse into update-cargo * update to new libp2p versions * Add metric for current epoch total balance (#5688) * Add metric for current epoch total balance --------- Co-authored-by: realbigsean <[email protected]> Co-authored-by: Mac L <[email protected]> Co-authored-by: Lion - dapplion <[email protected]> Co-authored-by: Pawan Dhananjay <[email protected]> Co-authored-by: Roman Krasiuk <[email protected]> Co-authored-by: Eitan Seri-Levi <[email protected]> Co-authored-by: antondlr <[email protected]> Co-authored-by: Jimmy Chen <[email protected]> Co-authored-by: Ærvin <[email protected]> Co-authored-by: Age Manning <[email protected]> Co-authored-by: João Oliveira <[email protected]> Co-authored-by: Michael Sproul <[email protected]>

Uncomment self_hosted_runner after PR Merge sigp#5137

86ceda6

antondlr changed the base branch from stable to unstable February 27, 2024 08:46

antondlr approved these changes Mar 4, 2024

View reviewed changes

jxs changed the base branch from unstable to stable March 4, 2024 18:31

jxs changed the base branch from stable to unstable March 4, 2024 18:32

antondlr added the v5.2.0 Q2 2024 label Mar 9, 2024

Merge branch 'unstable' into fix_todo

a62a8fc

michaelsproul added the ready-for-merge This PR is ready to merge. label Apr 30, 2024

mergify bot added a commit that referenced this pull request Apr 30, 2024

Merge of #5291

8bf09e8

mergify bot mentioned this pull request Apr 30, 2024

merge queue: embarking unstable (c8ffafb) and #5291 together #5663

Closed

5 tasks

michaelsproul mentioned this pull request Apr 30, 2024

Release v5.2.0 #5664

Merged

Merge branch 'unstable' of https://github.com/sigp/lighthouse into fi…

d96a5b9

…x_todo

mergify bot added a commit that referenced this pull request Apr 30, 2024

Merge of #5291

3b3dc80

mergify bot mentioned this pull request Apr 30, 2024

merge queue: embarking unstable (63fad7e) and #5291 together #5671

Closed

5 tasks

mergify bot merged commit aea02c6 into sigp:unstable Apr 30, 2024
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uncomment self_hosted_runner after PR Merge #5137 #5291

Uncomment self_hosted_runner after PR Merge #5137 #5291

Arvmor commented Feb 25, 2024

CLAassistant commented Feb 25, 2024 •

edited

Loading

antondlr commented Feb 27, 2024

Arvmor commented Feb 28, 2024

antondlr left a comment

Arvmor commented Mar 9, 2024

antondlr commented Mar 9, 2024

michaelsproul commented Apr 30, 2024

mergify bot commented Apr 30, 2024 •

edited

Loading

jimmygchen commented Apr 30, 2024

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024 •

edited

Loading

Uncomment self_hosted_runner after PR Merge #5137 #5291

Uncomment self_hosted_runner after PR Merge #5137 #5291

Conversation

Arvmor commented Feb 25, 2024

Issue Addressed

Proposed Changes

Additional Info

CLAassistant commented Feb 25, 2024 • edited Loading

antondlr commented Feb 27, 2024

Arvmor commented Feb 28, 2024

antondlr left a comment

Choose a reason for hiding this comment

Arvmor commented Mar 9, 2024

antondlr commented Mar 9, 2024

michaelsproul commented Apr 30, 2024

mergify bot commented Apr 30, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented Apr 30, 2024

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024 • edited Loading

✅ The pull request has been merged automatically

CLAassistant commented Feb 25, 2024 •

edited

Loading

mergify bot commented Apr 30, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented Apr 30, 2024 •

edited

Loading