Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove availability view trait #5544

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

realbigsean
Copy link
Member

Issue Addressed

Builds on top of #5420

Proposed Changes

We are now down to one implementation of the AvailabilityView trait. This PR removes the trait and migrates those methods to PendingComponents as well as all of the tests.

@realbigsean realbigsean added the ready-for-review The code is ready for review label Apr 10, 2024
@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 11, 2024
@realbigsean
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Apr 11, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3d4e6e2

mergify bot added a commit that referenced this pull request Apr 11, 2024
@mergify mergify bot merged commit 3d4e6e2 into sigp:unstable Apr 11, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants