Fix on-disk consensus context format

[michaelsproul]

Issue Addressed

Fix a regression in unstable that causes logs of the form:

ERRO Failed to maintain availability cache error: DecodeError(OffsetOutOfBounds(1157628160)), service: beacon

This was due to the addition of fields to ConsensusContext in the single-pass epoch processing PR. ConsensusContext is now part of our on-disk database schema via DietAvailabilityPendingExecutedBlock:

lighthouse/beacon_node/beacon_chain/src/data_availability_checker/state_lru_cache.rs

Lines 20 to 30 in 3058b96

	pub struct DietAvailabilityPendingExecutedBlock<E: EthSpec> {
	#[ssz(with = "ssz_tagged_signed_beacon_block_arc")]
	block: Arc<SignedBeaconBlock<E>>,
	state_root: Hash256,
	#[ssz(with = "ssz_tagged_signed_beacon_block")]
	parent_block: SignedBeaconBlock<E, BlindedPayload<E>>,
	parent_eth1_finalization_data: Eth1FinalizationData,
	confirmed_state_roots: Vec<Hash256>,
	consensus_context: ConsensusContext<E>,
	payload_verification_outcome: PayloadVerificationOutcome,
	}

Proposed Changes

• Define a new OnDiskConsensusContext struct which keeps only the previous fields.
• Convert between in-memory consensus contexts and the stable on-disk format as necessary.

[realbigsean]

DietAvailabilityPendingExecutedBlock is constructued on every block, and since OnDiskConsensusContext drops indexed_attestations, that cache would be dropped every block.

Could fix this easily by keeping the indexed_attestations field in OnDiskConsensusContext with #[ssz(skip_serializing, skip_deserializing)].

[michaelsproul]

Great catch, just pushed a fix

[realbigsean]

LGTM

[michaelsproul]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5a9e973