Component search loop #5696
Closed
Component search loop #5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
approved these changes
May 3, 2024
michaelsproul
added a commit
that referenced
this pull request
May 3, 2024
Squashed commit of the following: commit 3764895 Author: realbigsean <[email protected]> Date: Thu May 2 16:33:54 2024 -0400 return true on lookup completed to ensure child lookup is progressed commit 910b147 Author: realbigsean <[email protected]> Date: Thu May 2 16:27:05 2024 -0400 lookup trigger logging commit 56d88fb Author: realbigsean <[email protected]> Date: Thu May 2 16:22:05 2024 -0400 add cache for completed lookups
Merged
…mponent-search-loop
| peers: &[PeerId], | ||
| cx: &mut SyncNetworkContext<T>, | ||
| ) -> bool { | ||
| // If the lookup is complete, don't create a new one. | ||
| if self.completed_lookups.contains(&block_root) { | ||
| return true; |
There was a problem hiding this comment.
It might be nice to have a debug! log here to know when this is firing
1 task
|
I would prefer not to go with this solution, instead go for: |
|
closing for #5722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses: #5693
Suggestion by @dapplion: Adds a
completed_lookupstime cache, similar to thefailed_chainscache as a simple way to track and suppress lookups that have already been completed but are still being processed somewhereI also realized this PR delete spammy log #5672 would keep us from being able to distinguish current lookups triggered by unknown parents vs attestations easily in the logs, so I added a new enum
LookupTriggersolely for the purpose of distinguishing the two