Remove unused dependencies #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackintosh
added
ready-for-review
dapplion
approved these changes
May 22, 2024
michaelsproul
approved these changes
May 27, 2024
michaelsproul
added
ready-for-merge
|
I don't mind whether we add machete to CI. We already have quite good coverage for unused depdendencies via |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6f05863 |
This was referenced May 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removed the unused dependencies identified by cargo-machete.
Additional Info
We are running cargo-udeps in CI, but it seems imperfect as some unused dependencies were found by cargo-machete. Should we add cargo-machete to the CI job?