Fix BitVectors TestRandom implementation #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
electra
eserilev
changed the title
eserilev
changed the title
|
we could even target this at unstable? |
eserilev
force-pushed
the
fix_bit_vector_test_random_impl
branch
from
e6a64e4
to
e87cf1d
Compare
dapplion
approved these changes
May 30, 2024
michaelsproul
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at df6e1c9 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
For electra attestations a new field
committee_bits: BitVector<E::MaxCommitteesPerSlot>is introducedTheres some assumptions in
BitVectorsTestRandomimpl thatNis divisible by 8. For the minimal specMaxCommitteesPerSlot= 4. In this case, when generating a random bit vector, araw_bytesvec of length 1 is created that is filled with a randomly generated value. In some cases the randomly generated value has bits set that are higher thanraw_bytes.len(). This PR introduces some bit masking logic to theTestRandomimpl forBitVectorto ensure that we zero out bits >raw_bytes.len()in the case whereNisn't divisible by 8.This change should fix some failing electra networking tests. This PR along with other electra attestation PR's should get us passing CI for electra attestation changes. Thanks Michael for the assistance!