Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update criterion #5886

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Update criterion #5886

merged 2 commits into from
Jun 4, 2024

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Closes:

Proposed Changes

Update criterion and remove our transitive dependency on clap v2 as a result 🎉

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! dependencies Pull requests that update a dependency file labels Jun 4, 2024
@michaelsproul michaelsproul mentioned this pull request Jun 4, 2024
Closed
realbigsean
realbigsean approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@realbigsean
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jun 4, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7a7fc82

mergify bot added a commit that referenced this pull request Jun 4, 2024
@mergify
Merge of #5886
6af830c
@mergify mergify bot mentioned this pull request Jun 4, 2024
Closed
5 tasks
@mergify mergify bot merged commit 7a7fc82 into sigp:unstable Jun 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
code-quality dependencies Pull requests that update a dependency file low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @realbigsean