-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical state diffs #5978
Open
michaelsproul
wants to merge
56
commits into
unstable
Choose a base branch
from
tree-states-archive
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hierarchical state diffs #5978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
work-in-progress
PR is a work-in-progress
optimization
Something to make Lighthouse run more efficiently.
database
tree-states
Upcoming state and database overhaul
labels
Jun 21, 2024
I get a compilation error from xdelta3 trying to compile this branch: EDIT: Fixed (cropped previous text because it's long) |
looks like it might be a Mac thing I had to fork xdelta3 already, we should move it under sigp and patch it |
TODOsEDIT: completed |
TODO ~ Some metrics that we should add:
|
dapplion
reviewed
Jun 21, 2024
This was referenced Jul 3, 2024
* Add store cache size metrics * Add compress timer metrics * Add diff apply compute timer metrics * Add diff buffer cache hit metrics * Add hdiff buffer load times * Add blocks replayed metric * Move metrics to store * Future proof some metrics --------- Co-authored-by: Michael Sproul <[email protected]>
Ready for final review and merge. This is confirmed working on test infra, and all FIXMEs have been resolved. |
dapplion
reviewed
Sep 11, 2024
* Review PR comments and metrics * Comments * Add anchor metrics * drop prev comment * Update metadata.rs * Apply suggestions from code review --------- Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Lion - dapplion <[email protected]>
* Simplify database anchor * Update beacon_node/store/src/reconstruct.rs * Add migration for anchor * Fix and simplify light_client store tests * Fix incompatible config test
jimmygchen
reviewed
Oct 15, 2024
jimmygchen
reviewed
Oct 15, 2024
* New historic state cache * Add more metrics * State cache hit rate metrics * Fix store metrics * More logs and metrics * Fix logger * Ensure cached states have built caches :O * Replay blocks in preference to diffing * Two separate caches * Distribute cache build time to next slot * Re-plumb historic-state-cache flag * Clean up metrics * Update book * Update beacon_node/store/src/hdiff.rs Co-authored-by: Lion - dapplion <[email protected]> * Update beacon_node/store/src/historic_state_cache.rs Co-authored-by: Lion - dapplion <[email protected]> --------- Co-authored-by: Lion - dapplion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards-incompat
Backwards-incompatible API change
database
optimization
Something to make Lighthouse run more efficiently.
ready-for-review
The code is ready for review
tree-states
Upcoming state and database overhaul
v6.0.0
New major release for hierarchical state diffs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR contains the freezer DB changes from the main
tree-states
branch, bringing the small & efficient archive node database to stable Lighthouse 🎉Additional Info
(From @dapplion): Some resources to get up to speed with HDiff concepts: