add missing fields to get blob sidecars request #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
waiting-on-author
…d-missing-fields-get-blob-sidecars
eserilev
added
ready-for-review
jimmygchen
added
waiting-on-author
…d-missing-fields-get-blob-sidecars
eserilev
force-pushed
the
add-missing-fields-get-blob-sidecars
branch
from
a0e5092
to
81e6879
Compare
fetch from cache if its a head block
eserilev
force-pushed
the
add-missing-fields-get-blob-sidecars
branch
from
81e6879
to
969e4c7
Compare
eserilev
added
ready-for-review
michaelsproul
requested changes
Jul 29, 2024
michaelsproul
added
waiting-on-author
eserilev
added
ready-for-review
|
Tested and can confirm that the fields |
dapplion
approved these changes
Aug 10, 2024
michaelsproul
approved these changes
Aug 19, 2024
michaelsproul
added
ready-for-merge
Comment on lines
+273
to
+278
| let block = BlockId::blinded_block_by_root(&root, chain)?.ok_or_else(|| { | ||
| warp_utils::reject::custom_not_found(format!("beacon block with root {}", root)) | ||
| })?; | ||
|
|
||
| // Return the `BlobSidecarList` identified by `self`. | ||
| let blob_sidecar_list = chain |
There was a problem hiding this comment.
Now that we're loading the block and blobs together, it could be good to check that all the blobs are loaded, and return a 404 in case they aren't
Related to this issue:
I added (and then removed) the backwards-incompat tag because I thought this change may already accomplish this, but we don't have the check (yet), so it doesn't.
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0429158 |
5 tasks
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* add missing fields to get blob sidecars request * add fork versioned response impl * only compute the block root once * Merge branch 'unstable' of https://github.com/sigp/lighthouse into add-missing-fields-get-blob-sidecars * Merge branch 'unstable' of https://github.com/sigp/lighthouse into add-missing-fields-get-blob-sidecars * fetch root first fetch from cache if its a head block * fmt * always load from db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #5977
Proposed Changes
Adds missing fields to get blob sidecars request