Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade re-org log to INFO #6220

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Downgrade the WARN Beacon chain re-org log to INFO level.

Re-orgs are a normal part of node operation and completely unactionable by the node operator. Removing this warning is long overdue.

@michaelsproul michaelsproul added ready-for-review The code is ready for review UX-and-logs v5.3.0 Q3 2024 release with database changes! labels Aug 5, 2024
Co-authored-by: chonghe <[email protected]>
michaelsproul added a commit that referenced this pull request Aug 5, 2024
Squashed commit of the following:

commit b4b9c18
Author: Michael Sproul <[email protected]>
Date:   Mon Aug 5 12:25:19 2024 +1000

    Update book

    Co-authored-by: chonghe <[email protected]>

commit 5b09e44
Author: Michael Sproul <[email protected]>
Date:   Mon Aug 5 09:37:49 2024 +1000

    Downgrade re-org log to INFO
@chong-he
Copy link
Member

chong-he commented Aug 5, 2024

Looks good!

Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macladson macladson added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 5, 2024
@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Aug 5, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 612946b

@mergify mergify bot merged commit 612946b into sigp:release-v5.3.0 Aug 5, 2024
29 checks passed
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
* Downgrade re-org log to INFO

* Update book

Co-authored-by: chonghe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. UX-and-logs v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants