Add PeerDAS RPC import boilerplate #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
commented
Aug 7, 2024
| @@ -476,6 +477,24 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> { | |||
| }) | |||
| } | |||
|
|
|||
| /// Create a new `Work` event for some custody columns. `process_rpc_custody_columns` reports | |||
| /// the result back to sync. | |||
| pub fn send_rpc_custody_columns( | |||
There was a problem hiding this comment.
Future PR touching sync will consume this function
jimmygchen
reviewed
Aug 8, 2024
This was referenced Aug 13, 2024
jimmygchen
changed the base branch from
peerdas-network-boilerplate
to
unstable
jimmygchen
added
ready-for-review
realbigsean
reviewed
Aug 13, 2024
dapplion
force-pushed
the
peerdas-network-processor
branch
from
f428d17
to
8688065
Compare
dapplion
force-pushed
the
peerdas-network-processor
branch
from
77e0cb6
to
15881d0
Compare
|
@jimmygchen I have reverted the refactor of the *SameBlock types. This PR just extends same style as blobs Also rebased on unstable to clean the commits :) |
realbigsean
approved these changes
Aug 14, 2024
| @@ -181,6 +183,38 @@ impl<T: BeaconChainTypes> DataAvailabilityChecker<T> { | |||
| .put_kzg_verified_blobs(block_root, epoch, verified_blobs) | |||
| } | |||
|
|
|||
| /// Put a list of custody columns received via RPC into the availability cache. This performs KZG | |||
| /// verification on the blobs in the list. | |||
| #[allow(clippy::type_complexity)] | |||
There was a problem hiding this comment.
Suggested change
| #[allow(clippy::type_complexity)] |
i think this is not necessary
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5169e03 |
5 tasks
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Add PeerDAS RPC import boilerplate * revert refactor * Remove allow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Continue porting network changes of
dasbranch. Extends #6224Part of
Proposed Changes
Work:: RpcCustodyColumneventDataColumnsSameBlockas downstream code assumes that all submitted columns are in the same block. The implementation indasjust assumes this to be the case, but this PR makes this assumption explicit via a new type. I changed the gossip import method from accepting N columns to exactly 1, so we can assert that the single column is always part of the same block.