Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist data columns to store #6255

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

jimmygchen
Copy link
Member

Issue Addressed

This small PR contains some remaining changes from #5196 to persist data columns for blocks that have been made available

Built on top of #6237.

@jimmygchen jimmygchen added ready-for-review The code is ready for review do-not-merge das Data Availability Sampling das-unstable-merge labels Aug 13, 2024
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty straightforward

@jimmygchen jimmygchen changed the base branch from peerdas-network-rpc-handler to unstable August 13, 2024 23:39
@jimmygchen jimmygchen force-pushed the gossip-handling-store-wire-up branch from 96acf78 to bd95311 Compare August 13, 2024 23:42
@jimmygchen
Copy link
Member Author

I've rebased this back to unstable now the conga line's rebased and all targeting unstable.

@jimmygchen jimmygchen force-pushed the gossip-handling-store-wire-up branch from bd95311 to 2b3fb66 Compare August 14, 2024 00:04
@jimmygchen
Copy link
Member Author

Thanks for the quick review @realbigsean ! 🙏

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 14, 2024
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Aug 14, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 18df701

@mergify mergify bot merged commit 18df701 into unstable Aug 14, 2024
28 checks passed
@mergify mergify bot deleted the gossip-handling-store-wire-up branch August 14, 2024 04:36
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
* Persist data columns (from das PR sigp#5196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling das-unstable-merge ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants