Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data columns by root sync request #6273

Closed

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Part of

Proposed Changes

Add support inside sync network context to issue, track and complete data_columns_by_root requests.

This type of request will be issued by a higher order custody by root request. In summary:

  • Block lookup will trigger a custody by root request, code here: Add sync lookup custody request state #6257
  • Custody by root request will trigger data columns by root request(s): TODO
  • Data columns by root request complete: this PR

The handler of data_columns_by_root requests is quasi-identical to blobs_by_root request handler. Same verify conditions and completeness conditions.

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling das-unstable-merge labels Aug 16, 2024
@dapplion
Copy link
Collaborator Author

dapplion commented Aug 16, 2024

Closing for equal PR but from sigp repo

@dapplion dapplion closed this Aug 16, 2024
@dapplion dapplion deleted the peerdas-request-data-columns-by-root branch August 16, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling das-unstable-merge ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant