Remove generic E from RequestId

[jxs]

Issue Addressed

Continue cleaning up rpc code by removing unrequired generic E from request id, and passing MAX_BLOBS_PER_BLOCK when constructing a BlobsByRange request

[dapplion]

This value is the same on all requests, does it need to be appended to every request? Or can it be part of the handler struct

[jxs]

Hi Lion, good question, the thing is:

lighthouse/beacon_node/network/src/sync/network_context.rs

Lines 406 to 415 in 48dd3f3

	self.network_send
	.send(NetworkMessage::SendRequest {
	peer_id,
	request: RequestType::BlobsByRange(BlobsByRangeRequest {
	start_slot: *request.start_slot(),
	count: *request.count(),
	}),
	request_id: AppRequestId::Sync(SyncRequestId::RangeBlockAndBlobs { id }),
	})
	.map_err(|_| RpcRequestSendError::NetworkSendError)?;

the request is created here for example, it's outside of the Rpc NetworkBehaviour.
Also BlobsByRangeRequest::max_blobs_requested(&self) requires it, how would you envision storing max_blobs_per_block?
My objective is for Rpc to be completely unaware of E: EthSpec so that we can uncouple it from the rest of lighthouse and all its config values are passed dynamically.

[dapplion]

Actually, I take that back, if we increase the blob count we will have different requests with different limits at runtime. So okay with me to keep it on the request

[michaelsproul]

I don't think we should have added this field to BlobsByRangeRequest. It breaks the SSZ representation.

[AgeManning]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 772929f