Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement message time-bound dropping #555

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

AgeManning
Copy link
Member

@AgeManning AgeManning commented Nov 30, 2023

This implements a time-based approach to dropping messages.

There are two separate configurable time-bounds one for publish messages and one for forward messages.

Of particular note, there is still more work to be done:

  • Decide how to handle peers that are dropping messages
  • Split control messages to handle IHAVE/IWANT seperately, likely with their own time-bounds or the same as the forward time bound.

@AgeManning AgeManning merged commit 73ae996 into sigp:lighthouse-gossipsub Dec 4, 2023
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants