Add support for eMMC decode #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The decoder was updated to run in a more recent version of PulseView, using sdcard_sd as template. 2. Updated the command decoding to cover all the commands and responses from the eMMC v5.1 spec. 3. Fixed up some discrepancies, updated mismatching fields in commands and responses and performed some cleanup. 4. Minor touch ups, like decoding the device CURRENT_STATE field in the R1 response.
|
Hi @uwehermann, what to do to get this merged? |
|
Hello, thanks for your contribution. I would like to merge your changes but unfortunately, this is currently not possible. It makes no sense to maintain two separate PDs that support the same underlying protocol with some differences in the meaning of the data. If this was modified to share code with the sdcard_sd PD in a sensible way, it would make it much easier to maintain. For example, the common code could be moved out into a file common to sdcard_sd and emmc_sd and each PD could simply contain the stuff that's unique and/or specific to each PD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this adds support for the eMMC decoder.
It's based on the excellent work of:
https://github.com/gaodingpan/sigrok_emmc_decoder
https://github.com/radorodopski/sigrok_emmc_decoder
It should close this ticket:
https://sigrok.org/bugzilla/show_bug.cgi?id=1558