Skip to content

Commit

Permalink
build.yml: Remove individual PR messages as the step IDs won't work
Browse files Browse the repository at this point in the history
A step's ID must be unique per job. This cannot be done for matrix jobs, it looks like, since the value of ID doesn't seem to be interpreted.
  • Loading branch information
abraxa committed Aug 26, 2024
1 parent 744bf34 commit daaa08b
Showing 1 changed file with 0 additions and 96 deletions.
96 changes: 0 additions & 96 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,22 +133,6 @@ jobs:
name: artifact-pulseview-${{ matrix.target.target }}-${{ matrix.build_type.name }}-mxe
path: pulseview/build/contrib/pulseview*installer.exe

- name: Add artifact message to pull request
# Only relevant for pull requests
if: (github.event_name == 'pull_request')
uses: actions/github-script@v7
env:
PR_NOTES: |
pulseview-${{ env.ARTIFACT_VERSION }}-${{ matrix.target.target }}-${{ matrix.build_type.name }}-installer.exe created: ${{ env[format('steps.upload_pulseview-{0}_{1}_mxe_artifact.outputs.artifact-url', env.TARGET, env.BUILD_TYPE)] }}
with:
script: |
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: process.env.PR_NOTES
})

build_sigrok-cli_mxe:
name: sigrok-cli MXE build (${{ matrix.target.target }})
Expand Down Expand Up @@ -242,22 +226,6 @@ jobs:
name: artifact-sigrok-cli-${{ matrix.target.target }}-mxe
path: sigrok-cli/contrib/sigrok-cli*installer.exe

- name: Add artifact message to pull request
# Only relevant for pull requests
if: (github.event_name == 'pull_request')
uses: actions/github-script@v7
env:
PR_NOTES: |
sigrok-cli-${{ env.ARTIFACT_VERSION }}-${{ matrix.target.target }}-debug-installer.exe created: ${{ env[format('steps.upload_sigrok-cli_{0}_debug_mxe_artifact.outputs.artifact-url', env.TARGET)] }}
with:
script: |
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: process.env.PR_NOTES
})

build_pulseview_appimage:
name: PulseView AppImage build (${{ matrix.target.target }}) (${{ matrix.build_type.type }})
Expand Down Expand Up @@ -378,22 +346,6 @@ jobs:
name: artifact-pulseview-${{ matrix.target.target }}-${{ matrix.build_type.name }}-appimage
path: sigrok-build/ci/appimage/appimage-build/pulseview-*.appimage

- name: Add artifact message to pull request
# Only relevant for pull requests
if: (github.event_name == 'pull_request')
uses: actions/github-script@v7
env:
PR_NOTES: |
pulseview-${{ matrix.target.target }}-${{ matrix.build_type.name }}-appimage created: ${{ env[format('steps.upload_pulseview-{0}_{1}_appimage_artifact.outputs.artifact-url', env.TARGET, env.BUILD_TYPE)] }}
with:
script: |
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: process.env.PR_NOTES
})

build_sigrok-cli_appimage:
name: sigrok-cli AppImage build (${{ matrix.target.target }})
Expand Down Expand Up @@ -513,22 +465,6 @@ jobs:
run: |
echo 'Artifact URL is ${{ steps.upload_sigrok-cli_appimage_artifact.outputs.artifact-url }}'
- name: Add artifact message to pull request
# Only relevant for pull requests
if: (github.event_name == 'pull_request')
uses: actions/github-script@v7
env:
PR_NOTES: |
sigrok-cli-${{ env.ARTIFACT_VERSION }}-${{ matrix.target.target }}-debug.appimage created: ${{ env[format('steps.upload_sigrok-cli_{0}_appimage_artifact.outputs.artifact-url', env.TARGET)] }}
with:
script: |
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: process.env.PR_NOTES
})
build_pulseview_macos:
name: PulseView macOS build
Expand Down Expand Up @@ -627,22 +563,6 @@ jobs:
name: artifact-pulseview-macos
path: sigrok-build/ci/macos/pulseview*.dmg

- name: Add artifact message to pull request
# Only relevant for pull requests
if: (github.event_name == 'pull_request')
uses: actions/github-script@v7
env:
PR_NOTES: |
pulseview-${{ env.ARTIFACT_VERSION }}-${{ env.TARGET }}.dmg created: ${{ steps.upload_pulseview_appimage_artifact.outputs.artifact-url }}
with:
script: |
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: process.env.PR_NOTES
})

build_sigrok-cli_macos:
name: sigrok-cli macOS build
Expand Down Expand Up @@ -725,22 +645,6 @@ jobs:
name: artifact-sigrok-cli-macos
path: sigrok-build/ci/macos/sigrok-cli*.dmg

- name: Add artifact message to pull request
# Only relevant for pull requests
if: (github.event_name == 'pull_request')
uses: actions/github-script@v7
env:
PR_NOTES: |
sigrok-cli-${{ env.ARTIFACT_VERSION }}-${{ env.TARGET }}.dmg created: ${{ steps.upload_sigrok-cli_dmg_artifact.outputs.artifact-url', matrix.target.target }}
with:
script: |
github.rest.issues.createComment({
issue_number: ${{ github.event.pull_request.number }},
owner: context.repo.owner,
repo: context.repo.repo,
body: process.env.PR_NOTES
})

continuous_release_pulseview:
name: Create continuous PulseView release and add artifacts to it
Expand Down

0 comments on commit daaa08b

Please sign in to comment.