Skip to content

Commit

Permalink
sign: remove reg opts from sign blob
Browse files Browse the repository at this point in the history
Signed-off-by: Asra Ali <[email protected]>

update lint

Signed-off-by: Asra Ali <[email protected]>
  • Loading branch information
asraa committed Dec 6, 2022
1 parent 6566619 commit 66b660d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion cmd/cosign/cli/options/signblob.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ func (o *SignBlobOptions) AddFlags(cmd *cobra.Command) {
o.Fulcio.AddFlags(cmd)
o.Rekor.AddFlags(cmd)
o.OIDC.AddFlags(cmd)
o.Registry.AddFlags(cmd)

cmd.Flags().StringVar(&o.Key, "key", "",
"path to the private key file, KMS URI or Kubernetes Secret")
Expand Down
2 changes: 1 addition & 1 deletion cmd/cosign/cli/sign/sign_blob.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import (
)

// nolint
func SignBlobCmd(ro *options.RootOptions, ko options.KeyOpts, regOpts options.RegistryOptions, payloadPath string, b64 bool, outputSignature string, outputCertificate string, tlogUpload bool) ([]byte, error) {
func SignBlobCmd(ro *options.RootOptions, ko options.KeyOpts, payloadPath string, b64 bool, outputSignature string, outputCertificate string, tlogUpload bool) ([]byte, error) {
var payload internal.HashReader
var err error
var rekorBytes []byte
Expand Down
2 changes: 1 addition & 1 deletion cmd/cosign/cli/signblob.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func SignBlob() *cobra.Command {
o.OutputSignature = o.Output
}

if _, err := sign.SignBlobCmd(ro, ko, o.Registry, blob, o.Base64Output, o.OutputSignature, o.OutputCertificate, o.TlogUpload); err != nil {
if _, err := sign.SignBlobCmd(ro, ko, blob, o.Base64Output, o.OutputSignature, o.OutputCertificate, o.TlogUpload); err != nil {
return fmt.Errorf("signing %s: %w", blob, err)
}
}
Expand Down

0 comments on commit 66b660d

Please sign in to comment.