Resolves #522 set Created date to time of execution (#2108)

* #522 set Created date to time of execution Signed-off-by: Tobias Trabelsi <[email protected]> * #522 added check to only sign if previous date was zero and added date change to files as well Signed-off-by: Tobias Trabelsi <[email protected]> * added unit tests and removed log entry Signed-off-by: Tobias Trabelsi <[email protected]> * #522 review feedback Signed-off-by: Tobias Trabelsi <[email protected]> * #522 Apply suggestions from code review Co-authored-by: Jason Hall <[email protected]> Signed-off-by: Tobias Trabelsi <[email protected]> * #522 additional nil check Signed-off-by: Tobias Trabelsi <[email protected]> Co-authored-by: Tobias Trabelsi <[email protected]> Co-authored-by: Jason Hall <[email protected]>
sigstore · Jul 29, 2022 · ae99f7b · ae99f7b
1 parent 98396dd
commit ae99f7b
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 0 deletions.
diff --git a/pkg/oci/mutate/signatures.go b/pkg/oci/mutate/signatures.go
@@ -16,6 +16,8 @@
 package mutate
 
 import (
+	"time"
+
 	v1 "github.com/google/go-containerregistry/pkg/v1"
 	"github.com/google/go-containerregistry/pkg/v1/empty"
 	"github.com/google/go-containerregistry/pkg/v1/mutate"
@@ -36,10 +38,18 @@ func AppendSignatures(base oci.Signatures, sigs ...oci.Signature) (oci.Signature
 			Annotations: ann,
 		})
 	}
+
 	img, err := mutate.Append(base, adds...)
 	if err != nil {
 		return nil, err
 	}
+
+	// Set the Created date to time of execution
+	img, err = mutate.CreatedAt(img, v1.Time{Time: time.Now()})
+	if err != nil {
+		return nil, err
+	}
+
 	return &sigAppender{
 		Image: img,
 		base:  base,

diff --git a/pkg/oci/mutate/signatures_test.go b/pkg/oci/mutate/signatures_test.go
@@ -70,4 +70,10 @@ func TestAppendSignatures(t *testing.T) {
 	} else if got, want := len(sl), 3; got != want {
 		t.Errorf("len(Get()) = %d, wanted %d", got, want)
 	}
+
+	if testCfg, err := threeSig.ConfigFile(); err != nil {
+		t.Fatalf("ConfigFile() = %v", err)
+	} else if testCfg.Created.Time.IsZero() {
+		t.Errorf("Date of Signature was Zero")
+	}
 }
diff --git a/pkg/oci/static/file.go b/pkg/oci/static/file.go
@@ -17,6 +17,7 @@ package static
 
 import (
 	"io"
+	"time"
 
 	v1 "github.com/google/go-containerregistry/pkg/v1"
 	"github.com/google/go-containerregistry/pkg/v1/empty"
@@ -44,6 +45,12 @@ func NewFile(payload []byte, opts ...Option) (oci.File, error) {
 	if err != nil {
 		return nil, err
 	}
+
+	// Set the Created date to time of execution
+	img, err = mutate.CreatedAt(img, v1.Time{Time: time.Now()})
+	if err != nil {
+		return nil, err
+	}
 	return &file{
 		SignedImage: signed.Image(img),
 		layer:       layer,

diff --git a/pkg/oci/static/file_test.go b/pkg/oci/static/file_test.go
@@ -120,4 +120,14 @@ func TestNewFile(t *testing.T) {
 			t.Errorf("Payload() = %s, wanted %s", got, want)
 		}
 	})
+
+	t.Run("check date", func(t *testing.T) {
+		fileCfg, err := file.ConfigFile()
+		if err != nil {
+			t.Fatalf("ConfigFile() = %v", err)
+		}
+		if fileCfg.Created.Time.IsZero() {
+			t.Errorf("Date of Signature was Zero")
+		}
+	})
 }