Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement glob in CIP #1582

Closed
vaikas opened this issue Mar 10, 2022 · 0 comments · Fixed by #1584
Closed

Implement glob in CIP #1582

vaikas opened this issue Mar 10, 2022 · 0 comments · Fixed by #1584
Assignees
@vaikas
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Mar 10, 2022

Right now the CIP image_policies only supports exact match for images. Implement the glob behaviour as discussed in the API doc.
https://github.com/sigstore/cosign/blob/main/pkg/apis/config/image_policies.go#L85
@vaikas vaikas added the enhancement New feature or request label Mar 10, 2022
@vaikas vaikas self-assigned this Mar 10, 2022
vaikas added a commit to vaikas/cosign that referenced this issue Mar 10, 2022
@vaikas
Fix sigstore#1583 sigstore#1582. Disallow regex now until implemented.
f453b1a 
Signed-off-by: Ville Aikas <[email protected]>
@vaikas vaikas mentioned this issue Mar 10, 2022
Merged
vaikas added a commit to vaikas/cosign that referenced this issue Mar 10, 2022
@vaikas
Fix sigstore#1583 sigstore#1582. Disallow regex now until implemented.
86e1c85 
Signed-off-by: Ville Aikas <[email protected]>
vaikas added a commit to vaikas/cosign that referenced this issue Mar 10, 2022
@vaikas
Fix sigstore#1583 sigstore#1582. Disallow regex now until implemented.
5bf00b7 
Signed-off-by: Ville Aikas <[email protected]>
dlorenc pushed a commit that referenced this issue Mar 10, 2022
@vaikas
Fix #1583 #1582. Disallow regex now until implemented. (#1584)
bf799ed 
Signed-off-by: Ville Aikas <[email protected]>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this issue May 6, 2022
@vaikas @mlieberman85
Fix sigstore#1583 sigstore#1582. Disallow regex now until implemented. (
9eaab1a 
sigstore#1584)

Signed-off-by: Ville Aikas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaikas vaikas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1583 #1582. Disallow regex now until implemented. vaikas/cosign
1 participant
@vaikas