Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glob and regex should have omitempty #1613

Closed
mattmoor opened this issue Mar 15, 2022 · 2 comments · Fixed by #1617
Closed

glob and regex should have omitempty #1613

mattmoor opened this issue Mar 15, 2022 · 2 comments · Fixed by #1617
Assignees
@vaikas
Labels
bug Something isn't working

Comments

@mattmoor
Copy link
Member

Description

Now that we have multiple options here, these should be decorated with omitempty so that only the pattern specified shows up in the defaulted form:

cosign/pkg/apis/cosigned/v1alpha1/clusterimagepolicy_types.go

Lines 63 to 64 in d22c312

Glob string `json:"glob"`
Regex string `json:"regex"`

cc @vaikas @kkavitha @coyote240
@mattmoor mattmoor added the bug Something isn't working label Mar 15, 2022
@mattmoor
Copy link
Member Author

cc @jdolitsky

@hectorj2f
Copy link
Contributor

+1

@vaikas vaikas self-assigned this Mar 16, 2022
@vaikas vaikas mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaikas vaikas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename ca-key to ca-cert. Fix 1608, 1613 vaikas/cosign
3 participants
@mattmoor @hectorj2f @vaikas