Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ca-key to ca-cert. Fix 1608, 1613 #1617

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 16, 2022

Signed-off-by: Ville Aikas [email protected]

Summary

Rename ca-key in the cosigned api as per: #1608
Also while there, fixed #1613
Also, fixed a few other fields that should be omitempty and added +optional
tags where missing.

Ticket Link

Fixes

Release Note


Signed-off-by: Ville Aikas <[email protected]>
@cpanato cpanato requested a review from dlorenc March 16, 2022 13:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #1617 (9ec01a3) into main (36d7646) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   27.95%   27.95%           
=======================================
  Files         137      137           
  Lines        7826     7826           
=======================================
  Hits         2188     2188           
  Misses       5407     5407           
  Partials      231      231           
Impacted Files Coverage Δ
...apis/cosigned/v1alpha1/clusterimagepolicy_types.go 0.00% <ø> (ø)
...kg/apis/cosigned/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...cosigned/v1alpha1/clusterimagepolicy_validation.go 85.43% <66.66%> (ø)
...econciler/clusterimagepolicy/clusterimagepolicy.go 67.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d7646...9ec01a3. Read the comment docs.

@dlorenc dlorenc merged commit f8a6bad into sigstore:main Mar 16, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 16, 2022
@vaikas vaikas deleted the issue-1608 branch March 16, 2022 15:04
coyote240 pushed a commit to coyote240/cosign that referenced this pull request Mar 16, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glob and regex should have omitempty
4 participants