-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"make cosign" fails with missing ',' in argument list and malformed module path "embed" #1853
Labels
bug
Something isn't working
Comments
nealmcb
added a commit
to nealmcb/cosign
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also note need to `cd cmd/cosign`. See also: sigstore#1853 Signed-off-by: Neal McBurnett <[email protected]>
nealmcb
added a commit
to nealmcb/cosign
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also make `go build` also work the same way, from the root directory. See also: sigstore#1853 Signed-off-by: Neal McBurnett <[email protected]>
dlorenc
pushed a commit
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: #1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also make `go build` also work the same way, from the root directory. See also: #1853 Signed-off-by: Neal McBurnett <[email protected]>
I think this was fixed in #1850! |
This was not fixed in #1850 - that only has documentation changes. We discussed this on slack, and the Makefile still fails for me, but worked for someone else. So I'm not sure what the story is. |
pxp928
pushed a commit
to pxp928/cosign
that referenced
this issue
May 12, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also make `go build` also work the same way, from the root directory. See also: sigstore#1853 Signed-off-by: Neal McBurnett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Building
cosign
using theMakefile
fails. E.g. following the directions for includingpiv-tool
support, with either go1.17 or go1.18, fails like this. (Using the default make target also fails.)A workaround is the other step documented in TOKENS.md, but it requires a
cd
command first:The text was updated successfully, but these errors were encountered: