Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support image lists for verify-attestation #2356

Open
msmeissn opened this issue Oct 19, 2022 · 3 comments
Open

support image lists for verify-attestation #2356

msmeissn opened this issue Oct 19, 2022 · 3 comments
Labels
enhancement New feature or request oci Integration between Sigstore and OCI registries/images

Comments

@msmeissn
Copy link

Description

Currently the verify-attestation command does not handle imagelists well.

The SUSE BCI images are multi-architecture, and so accessing registry.suse.com/bci/golang:latest gives you an image list, not a single image.

see https://codeengineered.com/blog/2022/bci-slsa-attestation/ blog from Matt Farina.

I know verify-blob-attestation or explicit sha256 blob tagging could work, but it is far from userfriendly.

The verify-attestation command should probably be enhanced to select the architecture, or check all of them?

@msmeissn msmeissn added the enhancement New feature or request label Oct 19, 2022
@bailey-coding
Copy link

Thanks for sharing the blog posts! It definitely helps look at some cosign vs crane calls and how they're implemented.

I started digging into enabling this, by checking all of them, but we might want to support both.

We'll still need to do the ImageIndex call for a specific platform, but at least we can make fewer calls if we only care about a subset of them.

bailey-coding pushed a commit to bailey-coding/cosign that referenced this issue Oct 23, 2022
@bailey-coding
Copy link

I have some work in progress on my branch, but I'm not sure it even does the right thing and I am concerned the performance will be worse than the existing code.

main...justbaileym:cosign:b/support-image-lists

@bailey-coding
Copy link

For images, it should be possible to not degrade performance at all, if I properly understand how the manifests work.

For ImageIndex refs, the performance will be affected, since it requires an extra request, but if we support both all platforms and specific platforms, at least that'll enable folks to have an option with better performance too.

@znewman01 znewman01 added the oci Integration between Sigstore and OCI registries/images label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request oci Integration between Sigstore and OCI registries/images
Projects
None yet
Development

No branches or pull requests

3 participants