Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosigned doesn't check CronJobs #802

Closed
mattmoor opened this issue Sep 25, 2021 · 1 comment · Fixed by #809
Closed

cosigned doesn't check CronJobs #802

mattmoor opened this issue Sep 25, 2021 · 1 comment · Fixed by #809
Labels
bug Something isn't working

Comments

@mattmoor
Copy link
Member

Description

CronJob is a bit more complex because it deviates from the "PodSpecable" shape, but it would be good if we could validate it before it becomes Jobs.

cc @vaikas @n3wscott @dlorenc
@mattmoor mattmoor added the bug Something isn't working label Sep 25, 2021
@vaikas
Copy link
Contributor

vaikas commented Sep 27, 2021

I'll take a look at this.

@vaikas vaikas mentioned this issue Sep 27, 2021
Merged
vaikas added a commit to vaikas/cosign that referenced this issue Sep 27, 2021
@vaikas
fix issue sigstore#802, validate cronjobs
82b8ecb
@vaikas vaikas mentioned this issue Sep 27, 2021
Merged
vaikas added a commit to vaikas/cosign that referenced this issue Sep 27, 2021
@vaikas
fix issue sigstore#802, validate cronjobs
6a6c4dd 
Signed-off-by: Ville Aikas <[email protected]>
dekkagaijin pushed a commit that referenced this issue Sep 28, 2021
@vaikas
Fix issue #802, validate cronjobs (#809)
7ce09c8 
* fix issue #802, validate cronjobs
* drop k8s 1.19 due to knative.dev/pkg requiring 20+, add ut

Signed-off-by: Ville Aikas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #802, validate cronjobs vaikas/cosign
2 participants
@mattmoor @vaikas