Make the transparency log upload non-fatal. #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When keyless signing a private image today we prompt the user about uploading to Rekor, but in automation this prompt fails and on error this code panics (today). This change rewords the prompt, and makes the error path non-fatal (emits a WARNING, see below): ``` COSIGN_EXPERIMENTAL=true cosign sign ghcr.io/mattmoor/bundles < /dev/null Generating ephemeral keys... Retrieving signed certificate... Non-interactive mode detected, using device flow. Enter the verification code MVRL-JKVG in your browser at: https://oauth2.sigstore.dev/auth/device?user_code=MVRL-JKVG Code will be valid for 300 seconds Token received! Successfully verified SCT... "ghcr.io/mattmoor/bundles" appears to be a private repository, please confirm uploading to the transparency log at "https://rekor.sigstore.dev" [Y/N]: WARNING: skipping transparency log upload (use --force to upload from scripts): EOF MEYCIQCnyOa+oSLABA07Eb79eJ0/fmN0o0mUKUEXok/j3l7A3AIhAOH/fk7/bG8rO7mid2Iys4KIx8HKwznDbAAsO0sYHRWUmain ``` After this change, it should be possible to use cosign in keyless mode without `--force` on private images! Signed-off-by: Matt Moore <[email protected]>
22 tasks
dekkagaijin
approved these changes
Dec 1, 2021
|
this change it's great, but if it's only for automation, just curious if we could've just prefixed the automation with something like: |
|
@vaikas we also rely on user input elsewhere, e.g. password for private keys This was just an unnecessary and weird place for an interaction to occur |
|
Thanks @dekkagaijin thanks for the info, as I said was just curious :) |
|
@vaikas I meant the user prompt was weird and unnecessary! Interactions with you are always necessary and properly placed (especially when there's lager) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keyless signing a private image today we prompt the user about uploading to Rekor, but in automation this prompt fails and on error this code panics (today).
This change rewords the prompt, and makes the error path non-fatal (emits a WARNING, see below):
After this change, it should be possible to use cosign in keyless mode without
--forceon private images!Signed-off-by: Matt Moore [email protected]
Ticket Link
Related: actions/starter-workflows#1255
Release Note