Fix the unit tests with expired TUF metadata. #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests worked by mocking at the "isExpired" level. When the real files ARE expired, but we mock them to be NOT expired, the code continues down a path it shouldn't and fails later, trying to use expired metadata. We should fix this "better" by generating real expired and unexpired metadata, or changing the system clock somehow. Signed-off-by: Dan Lorenc <[email protected]>
hectorj2f
approved these changes
Jan 5, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
These tests worked by mocking at the "isExpired" level. When the real files ARE expired, but we mock them to be NOT expired, the code continues down a path it shouldn't and fails later, trying to use expired metadata. We should fix this "better" by generating real expired and unexpired metadata, or changing the system clock somehow. Signed-off-by: Dan Lorenc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests worked by mocking at the "isExpired" level. When the real files
ARE expired, but we mock them to be NOT expired, the code continues down a
path it shouldn't and fails later, trying to use expired metadata.
We should fix this "better" by generating real expired and unexpired metadata,
or changing the system clock somehow.
Signed-off-by: Dan Lorenc [email protected]
Summary
Ticket Link
Fixes
Release Note