Take OIDC client secret into account #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of empty string for OIDC client secret doesn't always work. Users should be able to specify their own. Closes sigstore#1309 Signed-off-by: Radoslav Gerganov <[email protected]>
rgerganov
force-pushed
the
oidc-client-secret
branch
from
6cc6800
to
ffebb4d
Compare
dlorenc
approved these changes
Jan 15, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
The default value of empty string for OIDC client secret doesn't always work. Users should be able to specify their own. Closes sigstore#1309 Signed-off-by: Radoslav Gerganov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of empty string for OIDC client secret doesn't always
work. Users should be able to specify their own.
Closes #1309
Signed-off-by: Radoslav Gerganov [email protected]