Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify checksum of downloaded utilities during CI #1322

Merged
merged 4 commits into from
Jan 15, 2022
Merged

Verify checksum of downloaded utilities during CI #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32a695f
remove installs without verifying checksum
bobcallaway Jan 14, 2022
bca5154
set path for extracted binary
bobcallaway Jan 14, 2022
8c98e7d
add additional messages during install
bobcallaway Jan 14, 2022
0684902
install kind version from matrix set instead of hardcoding
bobcallaway Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/donotsubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,17 @@ jobs:
TEMP_PATH="$(mktemp -d)"
PATH="${TEMP_PATH}:$PATH"

echo '::group::🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog'
curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b "${TEMP_PATH}" 2>&1
echo '::group::🐶 Installing reviewdog v0.13.1 ... https://github.com/reviewdog/reviewdog'
reviewdog_sha='08a5a323939101195af1d420ab6be3a50ec12f58e3419e3fcd07b6871f0b9a7e'
curl -s -L https://github.com/reviewdog/reviewdog/releases/download/v0.13.1/reviewdog_0.13.1_Linux_x86_64.tar.gz --output "${TEMP_PATH}/reviewdog.tar.gz"
echo '::group::🐶 Verifying checksum of download'
computed_sha=`sha256sum ${TEMP_PATH}/reviewdog.tar.gz|cut -d ' ' -f 1`
if [[ $reviewdog_sha != $computed_sha ]]; then
echo '::group::🐶 Failed to verify checksum, exiting!'
exit 1
fi
echo '::group::🐶 Checksum verified successfully, extracting reviewdog'
tar zxf "${TEMP_PATH}/reviewdog.tar.gz" -C ${TEMP_PATH} reviewdog
echo '::endgroup::'

echo '::group:: Running DO NOT SUBMIT with reviewdog 🐶 ...'
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/kind-e2e-cosigned.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ jobs:
# https://github.com/kubernetes-sigs/kind/issues/845
sudo mkdir -p /tmp/etcd
sudo mount -t tmpfs tmpfs /tmp/etcd
curl -Lo ./kind https://github.com/kubernetes-sigs/kind/releases/download/${{ matrix.kind-version }}/kind-$(uname)-amd64
chmod +x ./kind
sudo mv kind /usr/local/bin
go install sigs.k8s.io/kind@${{ matrix.kind-version }}

- name: Configure KinD Cluster
run: |
Expand Down