Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter error on main #1484

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Fix linter error on main #1484

merged 1 commit into from
Feb 18, 2022

Conversation

priyawadhwa
Copy link
Contributor

Signed-off-by: Priya Wadhwa [email protected]

Summary

Ticket Link

Fixes

Release Note


Signed-off-by: Priya Wadhwa <[email protected]>
@priyawadhwa priyawadhwa changed the title fix lint Fix linter error on main Feb 18, 2022
@priyawadhwa priyawadhwa merged commit c976efd into sigstore:main Feb 18, 2022
@priyawadhwa priyawadhwa deleted the fix branch February 18, 2022 20:33
priyawadhwa added a commit to priyawadhwa/cosign that referenced this pull request Feb 18, 2022
Signed-off-by: Priya Wadhwa <[email protected]>
@github-actions github-actions bot added this to the v1.6.0 milestone Feb 18, 2022
dlorenc added a commit that referenced this pull request Feb 18, 2022
* Merge pull request from GHSA-ccxc-vr6p-4858

* Make sure signature in Rekor bundle matches signature being verified

Signed-off-by: Priya Wadhwa <[email protected]>

* Only print "fulcio verified" when using Fulcio

Currently we tell users that we've verified against the Fulcio root
trust when verifying but this isn't always true. This work ensures we
only say this when we actually use the Fulcio root cert for
verification.

Signed-off-by: Nathan Smith <[email protected]>

* Add e2e test

Signed-off-by: Nathan Smith <[email protected]>

Co-authored-by: Priya Wadhwa <[email protected]>

* fix lint (#1484)

Signed-off-by: Priya Wadhwa <[email protected]>

* Manual merge conflict resolution in e2e_test.

Signed-off-by: Dan Lorenc <[email protected]>

Co-authored-by: Nathan Smith <[email protected]>
Co-authored-by: Dan Lorenc <[email protected]>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: Priya Wadhwa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants