Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up some of the shared workflows #1490

Merged
merged 7 commits into from
Feb 22, 2022
Merged

Conversation

mattmoor
Copy link
Member

This picks up a shared definition of DO NOT SUBMIT to avoid divergent shell code.

This also picks up our KinD diagnostic dumping logic from downstream, which we've been using to debug assorted KinD-based failures.

I have a few more workflows on my list that we can share this way, and I'll likely keep adding them here.

@cpanato Not sure what the best way of getting this to use the dependabot form is, so PTAL and LMK how best to adjust this. We haven't cut a release yet, but we can once we've gotten a bunch more of our workflows shared this way.

Ticket Link

N/A

Release Note

NONE

We've been using this downstream, and it is a nice way of getting a whole bunch of information from the KinD cluster on failures to debug things.

Signed-off-by: Matt Moore <[email protected]>
@mattmoor
Copy link
Member Author

I think we should probably snap a v1 before we merge this (and/or pin to a commit), but I wanted to find out from @cpanato the best way to align with what we do here.

-level="error"

echo '::endgroup::'
uses: chainguard-dev/actions/donotsubmit@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use a git hash instead of main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cpanato
Copy link
Member

cpanato commented Feb 22, 2022

@mattmoor, we need to add the following in the dependabot.yml definition

  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "daily"

then it will check the actions/jobs and update them according

Signed-off-by: Matt Moore <[email protected]>
@mattmoor
Copy link
Member Author

Added the dependabot config as well.

.github/dependabot.yml Outdated Show resolved Hide resolved
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Signed-off-by: Matt Moore <[email protected]>
@mattmoor mattmoor merged commit 8c54ae1 into sigstore:main Feb 22, 2022
@mattmoor mattmoor deleted the kind-diag branch February 22, 2022 16:04
@github-actions github-actions bot added this to the v1.6.0 milestone Feb 22, 2022
hatmarch pushed a commit to hatmarch/cosign that referenced this pull request Apr 19, 2022
* Use a shared action for dumping KinD diagnostics and DO NOT SUBMIT.

We've been using this downstream, and it is a nice way of getting a whole bunch of information from the KinD cluster on failures to debug things.

Signed-off-by: Matt Moore <[email protected]>

* Add the nodiff action to the party

Signed-off-by: Matt Moore <[email protected]>

* Start to consume the whitespace actions

Signed-off-by: Matt Moore <[email protected]>

* Start to consume the go formatting actions

Signed-off-by: Matt Moore <[email protected]>

* Pin SHAs

Signed-off-by: Matt Moore <[email protected]>

* Add dependabot config for bumping actions

Signed-off-by: Matt Moore <[email protected]>

* Add newline at EOF

Signed-off-by: Matt Moore <[email protected]>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
* Use a shared action for dumping KinD diagnostics and DO NOT SUBMIT.

We've been using this downstream, and it is a nice way of getting a whole bunch of information from the KinD cluster on failures to debug things.

Signed-off-by: Matt Moore <[email protected]>

* Add the nodiff action to the party

Signed-off-by: Matt Moore <[email protected]>

* Start to consume the whitespace actions

Signed-off-by: Matt Moore <[email protected]>

* Start to consume the go formatting actions

Signed-off-by: Matt Moore <[email protected]>

* Pin SHAs

Signed-off-by: Matt Moore <[email protected]>

* Add dependabot config for bumping actions

Signed-off-by: Matt Moore <[email protected]>

* Add newline at EOF

Signed-off-by: Matt Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants