Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix piping 'cosign verify' using fulcio/rekor #1590

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

marcofranssen
Copy link
Contributor

@marcofranssen marcofranssen commented Mar 10, 2022

Summary

Piping cosign verify with experimental mode is broken in v1.6.0.

$ COSIGN_EXPERIMENTAL=1 cosign verify-attestation ghcr.io/marcofranssen/slsa-workflow-examples-docker@sha256:44aeae57e33b680de437fb49a350adf157aeb5d5b5f4dcbb1103053bd9b415df | jq '.payload |= @base64d | .payload | fromjson | select(.predicateType == "https://spdx.dev/Document") | .predicate.Data | fromjson'

Verification for ghcr.io/marcofranssen/slsa-workflow-examples-docker@sha256:44aeae57e33b680de437fb49a350adf157aeb5d5b5f4dcbb1103053bd9b415df --
The following checks were performed on each of these signatures:
  - The cosign claims were validated
  - Existence of the claims in the transparency log was verified offline
  - Any certificates were verified against the Fulcio roots.
parse error: Invalid numeric literal at line 1, column 12

Release Note

Fixes piping `cosign verify` to other commands in shell when using experimental mode

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1590 (944725c) into main (0cdde4a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1590   +/-   ##
=======================================
  Coverage   27.46%   27.46%           
=======================================
  Files         137      137           
  Lines        7741     7741           
=======================================
  Hits         2126     2126           
  Misses       5386     5386           
  Partials      229      229           
Impacted Files Coverage Δ
cmd/cosign/cli/verify/verify.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdde4a...944725c. Read the comment docs.

@dlorenc dlorenc merged commit c0f8e37 into sigstore:main Mar 10, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 10, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants