Validate a public key in a secret is valid. #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: sigstore#1596 secret key contains valid public key. Signed-off-by: Ville Aikas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
- Coverage 27.96% 27.94% -0.03%
==========================================
Files 137 137
Lines 7789 7791 +2
==========================================
- Hits 2178 2177 -1
- Misses 5383 5385 +2
- Partials 228 229 +1
Continue to review full report at Codecov.
|
cpanato
approved these changes
Mar 14, 2022
|
there are some unused variables |
Signed-off-by: Ville Aikas <[email protected]>
cpanato
approved these changes
Mar 14, 2022
hectorj2f
approved these changes
Mar 14, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Validate a public key in a secret is valid. Fixes: sigstore#1596 secret key contains valid public key. Signed-off-by: Ville Aikas <[email protected]> * Remove unused variable. Signed-off-by: Ville Aikas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1596
secret key contains valid public key.
Signed-off-by: Ville Aikas [email protected]
Summary
Ticket Link
Fixes
Release Note