Support non-ECDSA public keys in certificates #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply loads the verifier based on key type, rather than assuming the key is ECDSA. Signed-off-by: Hayden Blauzvern <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1740 +/- ##
=======================================
Coverage 29.52% 29.52%
=======================================
Files 141 141
Lines 8502 8502
=======================================
Hits 2510 2510
Misses 5718 5718
Partials 274 274
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 11, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This simply loads the verifier based on key type, rather than assuming the key is ECDSA. Signed-off-by: Hayden Blauzvern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply loads the verifier based on key type, rather than assuming
the key is ECDSA.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Ticket Link
Fixes
Release Note