Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallelization for processing policies / authorities. #1795

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Apr 23, 2022

Signed-off-by: Ville Aikas [email protected]

Summary

Since processing policies / attestations can be semi time consuming and there can be
multiple CIP that matches a single image, parallelize them.

Ticket Link

Fixes

Release Note


@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #1795 (f5cca36) into main (8cac645) will increase coverage by 0.24%.
The diff coverage is 77.08%.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
+ Coverage   32.16%   32.41%   +0.24%     
==========================================
  Files         146      146              
  Lines        9208     9253      +45     
==========================================
+ Hits         2962     2999      +37     
- Misses       5898     5904       +6     
- Partials      348      350       +2     
Impacted Files Coverage Δ
pkg/cosign/kubernetes/webhook/validator.go 75.22% <77.08%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cac645...f5cca36. Read the comment docs.

dlorenc
dlorenc previously approved these changes Apr 24, 2022
@vaikas vaikas merged commit 683a6c0 into sigstore:main Apr 24, 2022
@vaikas vaikas deleted the parallelize branch April 24, 2022 04:30
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 24, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
…1795)

* Add parallelization for processing policies / authorities.

Signed-off-by: Ville Aikas <[email protected]>

* Simplify by removing the wg. If error encountered, create an internal
error.

Signed-off-by: Ville Aikas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants