Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third_party #2166

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Remove third_party #2166

merged 1 commit into from
Aug 16, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Aug 16, 2022

Signed-off-by: Jason Hall [email protected]

third_party/VENDOR-LICENSE was previously generated so it could be included in ko-built images (e.g., policy-controller) by being symlinked into cmd/policy-controller/kodata. That was removed and put into its own repo, removing the need for these licenses in the repo.

These files aren't updated by any automated process since #2080, so if we think we still need these (e.g., to symlink them for inclusion into a cosign container image), we should at least understand why and make sure they stay up-to-date automatically.

If we decide we need these, we should reinstate update-codegen.sh (maybe with a better name) and the CI check that ensures there aren't diffs.

Release Note

NONE

Documentation

NONE

cc @vaikas

Signed-off-by: Jason Hall <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #2166 (c14a728) into main (1a9027c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2166   +/-   ##
=======================================
  Coverage   26.26%   26.26%           
=======================================
  Files         130      130           
  Lines        7615     7615           
=======================================
  Hits         2000     2000           
  Misses       5359     5359           
  Partials      256      256           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlorenc dlorenc merged commit 026523a into sigstore:main Aug 16, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 16, 2022
cldmnky pushed a commit to cldmnky/cosign that referenced this pull request Aug 21, 2022
Signed-off-by: Jason Hall <[email protected]>

Signed-off-by: Jason Hall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants